Remove unnecessary FN type information from OPCache #5029
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class entry information is not used right now (see TODO lower in the file). Once that is implemented, accuracy will improve, yes. |
nikic
approved these changes
Dec 20, 2019
|
And because I didn't actually answer the question: Yes, it's okay to also drop those that contain MAY_BE_OBJECT. |
kocsismate
force-pushed
the
remove-fn
branch
from
fb6473c to
603c74b
Compare
|
Thank you for all the information :) I included the functions in question and rebased to fresh master. I'll apply the changes after successful CI run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can I also remove the items where there is a
MAY_BE_OBJECTin theFNdefinition like fordate_modify()? Will/would it improve the accuracy of DCE (or any other optimization for which this dataset is used) due to the fact that the exact class is known?(The build will be red because master currently fails)